feat: add metrics to api and recon #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add metrics to ceramic-api and recon crates. Additionally some small build fixes for tokio
AaronGoldman
reviewed
Jan 8, 2024
Makefile
Outdated
| @@ -50,7 +52,7 @@ check-kubo-rpc-server: | |||
|
|
|||
| .PHONY: release | |||
| release: | |||
| RUSTFLAGS="-D warnings" cargo build -p ceramic-one --locked --release | |||
| RUSTFLAGS="-D warnings" $(CARGO) build -p ceramic-one --locked --release | |||
There was a problem hiding this comment.
the RUSTFLAGS is redefined in the $(CARGO)
should CARGO = RUSTFLAGS='--cfg tokio_unstable' cargo
be more like CARGO = RUSTFLAGS=$RUSTFLAGS + '--cfg tokio_unstable' cargo
There was a problem hiding this comment.
Updated the Makefile to handle appending to RUSTFLAGS. Thanks for catching that
AaronGoldman
approved these changes
Jan 9, 2024
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics to ceramic-api and recon crates.
Additionally some small build fixes for tokio